Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClassMustBeFinal issue #11279

Merged
merged 15 commits into from
Feb 14, 2025
Merged

Add ClassMustBeFinal issue #11279

merged 15 commits into from
Feb 14, 2025

Conversation

danog
Copy link
Collaborator

@danog danog commented Feb 13, 2025

No description provided.

@danog danog changed the title Add ClassMustBeFinal isse Add ClassMustBeFinal issue Feb 13, 2025
@danog danog added the release:feature The PR will be included in 'Features' section of the release notes label Feb 13, 2025
@danog danog marked this pull request as ready for review February 14, 2025 11:09
@danog danog merged commit a27feaf into 6.x Feb 14, 2025
95 of 97 checks passed
@danog danog deleted the ClassMustBeFinal branch February 14, 2025 11:09
@jkowalleck
Copy link

jkowalleck commented Feb 16, 2025

i'd consider this a breaking change.
for the same code base, psalm6.5.1 passed, but psalm6.6.0 exited with errors.

Error: .../foophp:133:7: ClassMustBeFinal: Class Foo\Bar is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)

adding new rules - 👍
is it just me, or is this actually enabled per default?

@danog
Copy link
Collaborator Author

danog commented Feb 16, 2025

This was never the case with Psalm, new issues were always introduced in minors, never in majors: majors were only used for major API changes (which affect plugins).

I understand phpstan uses a different approach with bleeding edge, but this was never the case with Psalm.

GromNaN added a commit to mongodb/mongo-php-library that referenced this pull request Feb 17, 2025
GromNaN added a commit to mongodb/mongo-php-library that referenced this pull request Feb 18, 2025
* Bump tests/drivers-evergreen-tools from `f43767d` to `2c6869e`

Bumps [tests/drivers-evergreen-tools](https://github.com/mongodb-labs/drivers-evergreen-tools) from `f43767d` to `2c6869e`.
- [Commits](mongodb-labs/drivers-evergreen-tools@f43767d...2c6869e)

---
updated-dependencies:
- dependency-name: tests/drivers-evergreen-tools
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Lock psalm version

vimeo/psalm#11279

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jérôme Tamarelle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants